[RPC] Improve client error recovery #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM modulo that minor comment on the test. It's not a big deal, but it would be nice to perhaps replace the I approved the changes as I don't have anything else to add other than the above comment |
pnwamk
suggested changes
Aug 25, 2021
pnwamk
approved these changes
Aug 25, 2021
|
With the exception of an expected "Unknown state ID" error (this time on ubuntu!) the relevant bits of the CI all pass, so I'm merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates a change from argo which should resolve #1259
This PR also adds a test which shows that the client can now continue after an error, but does not include the exact example given in the issue above. Is it worth trying to get working an example exactly like the above? (i.e. using
safewith different SAT solvers?)