Attempt to fix allowed test failure on Windows #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They seem to hang instead of failing at the moment, so until we get them working it seems like it's better to just leave them out.
kquick
approved these changes
Jul 9, 2021
There was a problem hiding this comment.
It's not clear what's wrong with the windows CI builds, but it also doesn't seem to be related to the code or the CI configs, so I agree that disabling them for now to get green CI is more useful.
Looks like the actual test failure is probably a transient network issue.
I'm not sure why the windows test is marked as "skipped" as opposed to just being gone; I'm slightly concerned that will result in yellow status instead of a green checkmark but maybe it's just a sync comparison between this PR and master that will go away when the merge happens.
|
Yeah, I just re-started the jobs in the hop that the failed test will work this time. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.