Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support for FFI #1394

Closed
qsctr opened this issue Aug 12, 2022 · 0 comments · Fixed by #1438
Closed

Windows support for FFI #1394

qsctr opened this issue Aug 12, 2022 · 0 comments · Fixed by #1438
Labels
FFI Foreign function interface windows Specific to Cryptol on the Windows platform
Projects
FFI

Comments

@qsctr
Copy link
Contributor

qsctr commented Aug 12, 2022

In #1376 we held off on Windows support for FFI due to issues with packaging libffi on Windows detailed in #1090 (comment). But now that we have static linking of libffi on all platforms with libffi-0.2, Windows support should just be a matter of using the appropriate functions from the Win32 package to dynamically load shared libraries. We also need to figure out how to make the FFI tests work on Windows as well.
@qsctr qsctr added FFI Foreign function interface windows Specific to Cryptol on the Windows platform labels Aug 12, 2022
@qsctr qsctr added this to To do in FFI Aug 12, 2022
RyanGlScott added a commit that referenced this issue Sep 20, 2022
@RyanGlScott
Support FFI on Windows
7178980 
This patch:

* Adds the appropriate conditional logic to use the `Win32` library to
  dynamically load shared libraries on Windows.
* Tweaks some FFI-related test cases to make them work portably on Windows. I
  have left comments describing each of the non-obvious tweaks that I had to
  make.
* Updates the reference manual accordingly.

Fixes #1394.
@RyanGlScott RyanGlScott mentioned this issue Sep 20, 2022
Merged
RyanGlScott added a commit that referenced this issue Sep 23, 2022
@RyanGlScott
Support FFI on Windows
f71934f 
This patch:

* Adds the appropriate conditional logic to use the `Win32` library to
  dynamically load shared libraries on Windows.
* Tweaks some FFI-related test cases to make them work portably on Windows. I
  have left comments describing each of the non-obvious tweaks that I had to
  make.
* Updates the reference manual accordingly.

Fixes #1394.
RyanGlScott added a commit that referenced this issue Sep 24, 2022
@RyanGlScott
Support FFI on Windows
27ac8d9 
This patch:

* Adds the appropriate conditional logic to use the `Win32` library to
  dynamically load shared libraries on Windows.
* Tweaks some FFI-related test cases to make them work portably on Windows. I
  have left comments describing each of the non-obvious tweaks that I had to
  make.
* Updates the reference manual accordingly.

Fixes #1394.
@RyanGlScott RyanGlScott moved this from To do to Done in FFI Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FFI Foreign function interface windows Specific to Cryptol on the Windows platform
Projects
FFI
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support FFI on Windows GaloisInc/cryptol
1 participant
@qsctr