You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Cryptol's CI does not run after a new release is tagged with git push --tags. We have most of the infrastructure in place to do this, but we're missing a few key steps. In particular:
I believe there is a typo in the regex we use for checking tag names:
The ? character doesn't really make sense as the first character in a regex, since it's meant to represent that the preceding character is optional. I think that if we deleted the first ? character, the rest of the regex would behave as expected.
Cryptol's CI does not run after a new release is tagged with
git push --tags
. We have most of the infrastructure in place to do this, but we're missing a few key steps. In particular:I believe there is a typo in the regex we use for checking tag names:
cryptol/.github/workflows/ci.yml
Line 4 in 8cca245
The
?
character doesn't really make sense as the first character in a regex, since it's meant to represent that the preceding character is optional. I think that if we deleted the first?
character, the rest of the regex would behave as expected.On this line:
cryptol/.github/workflows/ci.yml
Line 315 in 8cca245
I believe we should also check for
if: ... || needs.config.outputs.release == 'true'
, similarly to how it's done here in SAW's CI.The text was updated successfully, but these errors were encountered: