Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI not triggered after a release is tagged #1351

Closed
RyanGlScott opened this issue May 16, 2022 · 0 comments · Fixed by #1356
Closed

CI not triggered after a release is tagged #1351

RyanGlScott opened this issue May 16, 2022 · 0 comments · Fixed by #1356
Labels
CI Continuous integration
Milestone

Comments

@RyanGlScott
Copy link
Contributor

Cryptol's CI does not run after a new release is tagged with git push --tags. We have most of the infrastructure in place to do this, but we're missing a few key steps. In particular:

  • I believe there is a typo in the regex we use for checking tag names:

    tags: ["?[0-9]+.[0-9]+(.[0-9]+)?"]

    The ? character doesn't really make sense as the first character in a regex, since it's meant to represent that the preceding character is optional. I think that if we deleted the first ? character, the rest of the regex would behave as expected.

  • On this line:

    if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'

    I believe we should also check for if: ... || needs.config.outputs.release == 'true', similarly to how it's done here in SAW's CI.

@RyanGlScott RyanGlScott added the CI Continuous integration label May 16, 2022
@RyanGlScott RyanGlScott added this to the 2.14.0 milestone May 16, 2022
RyanGlScott added a commit that referenced this issue May 19, 2022
This fixes the regex used to detect tagged releases and runs the
`build-push-image` job for tagged releases.

Fixes #1351.
RyanGlScott added a commit that referenced this issue May 19, 2022
This fixes the regex used to detect tagged releases and runs the
`build-push-image` job for tagged releases.

Fixes #1351.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant