Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saw Issue #709 #502

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Saw Issue #709 #502

merged 1 commit into from
Jun 23, 2020

Conversation

ChrisEPhifer
Copy link
Member

I've reworded some of the error messages in the LLVM memory model to use language such as "readonly" and "marked as readonly" rather than "not mutable" or "immutable", per saw-script issue #709.

@ChrisEPhifer ChrisEPhifer requested a review from atomb June 23, 2020 19:58
atomb
atomb approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for doing this. :) At some point, I think the "Invalidation" message could be re-worded to something that'll make more sense to a user, but I'm not yet sure what the right text would be. I don't want to hold this up waiting on that.

@ChrisEPhifer ChrisEPhifer merged commit 6cd20d5 into master Jun 23, 2020
@ChrisEPhifer ChrisEPhifer deleted the fix/saw-issue-709 branch June 23, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomb atomb atomb approved these changes

Assignees
No one assigned
Labels
crucible llvm UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisEPhifer @atomb