Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exe:crucible-jvm and exe:crux-go builds broken after f328d93 #899

Closed
RyanGlScott opened this issue Oct 28, 2021 · 4 comments · Fixed by #904
Closed

exe:crucible-jvm and exe:crux-go builds broken after f328d93 #899

RyanGlScott opened this issue Oct 28, 2021 · 4 comments · Fixed by #904

Comments

@RyanGlScott
Copy link
Contributor

After f328d93, the exe:crucible-jvm build fails with:

$ cabal build exe:crucible-jvm
Build profile: -w ghc-8.10.4 -O1
In order, the following will be built (use -v for more details):
 - crucible-jvm-0.2 (exe:crucible-jvm) (file tool/Main.hs changed)
Preprocessing executable 'crucible-jvm' for crucible-jvm-0.2..
Building executable 'crucible-jvm' for crucible-jvm-0.2..
[2 of 2] Compiling Main             ( tool/Main.hs, /home/rscott/Documents/Hacking/Haskell/crucible/dist-newstyle/build/x86_64-linux/ghc-8.10.4/crucible-jvm-0.2/x/crucible-jvm/build/crucible-jvm/crucible-jvm-tmp/Main.o )

tool/Main.hs:178:50: error:
    Not in scope: type constructor or class ‘Crux.SimulatorCallback’
    Perhaps you meant ‘Crux.SimulatorCallbacks’ (imported from Crux)
    Neither ‘Crux’, ‘Crux.Config.Common’, ‘Crux.Log’,
            ‘Crux.Model’ nor ‘Crux.Types’ exports ‘SimulatorCallback’.
    |
178 | simulateJVM :: Crux.CruxOptions -> JVMOptions -> Crux.SimulatorCallback msgs
    |                                                  ^^^^^^^^^^^^^^^^^^^^^^

tool/Main.hs:179:26: error:
    Not in scope: data constructor ‘Crux.SimulatorCallback’
    Perhaps you meant one of these:
      ‘Crux.SimulatorCallbacks’ (imported from Crux),
      variable ‘Crux.getSimulatorCallbacks’ (imported from Crux)
    Neither ‘Crux’, ‘Crux.Config.Common’, ‘Crux.Log’,
            ‘Crux.Model’ nor ‘Crux.Types’ exports ‘SimulatorCallback’.
    |
179 | simulateJVM copts opts = Crux.SimulatorCallback $ \sym _maybeOnline -> do
    |                          ^^^^^^^^^^^^^^^^^^^^^^

cc @langston-barrett

@RyanGlScott
Copy link
Contributor Author

exe:crux-go is similarly affected:

$ cabal build exe:crux-go --constraint="aeson<2.0"
Build profile: -w ghc-8.10.4 -O1
In order, the following will be built (use -v for more details):
 - crucible-go-0.1.0.0 (exe:crux-go) (file tool/Main.hs changed)
Preprocessing executable 'crux-go' for crucible-go-0.1.0.0..
Building executable 'crux-go' for crucible-go-0.1.0.0..
[2 of 2] Compiling Main             ( tool/Main.hs, /home/rscott/Documents/Hacking/Haskell/crucible/dist-newstyle/build/x86_64-linux/ghc-8.10.4/crucible-go-0.1.0.0/x/crux-go/build/crux-go/crux-go-tmp/Main.o )

tool/Main.hs:41:48: error:
    Not in scope: type constructor or class ‘Crux.SimulatorCallback’
    Perhaps you meant ‘Crux.SimulatorCallbacks’ (imported from Crux)
    Neither ‘Crux’ nor ‘Crux.Config.Common’ exports ‘SimulatorCallback’.
   |
41 | simulateGo :: Crux.CruxOptions -> GoOptions -> Crux.SimulatorCallback msgs
   |                                                ^^^^^^^^^^^^^^^^^^^^^^

tool/Main.hs:42:26: error:
    Not in scope: data constructor ‘Crux.SimulatorCallback’
    Perhaps you meant one of these:
      ‘Crux.SimulatorCallbacks’ (imported from Crux),
      variable ‘Crux.getSimulatorCallbacks’ (imported from Crux)
    Neither ‘Crux’ nor ‘Crux.Config.Common’ exports ‘SimulatorCallback’.
   |
42 | simulateGo copts _opts = Crux.SimulatorCallback $ \sym _maybeOnline -> do
   |                          ^^^^^^^^^^^^^^^^^^^^^^

@RyanGlScott RyanGlScott changed the title exe:crucible-jvm build broken after f328d93 exe:crucible-jvm and exe:crux-go builds broken after f328d93 Oct 28, 2021
@langston-barrett langston-barrett self-assigned this Oct 29, 2021
@langston-barrett
Copy link
Contributor

It's easy to forget these when they don't build in CI! Will fix.

@RyanGlScott
Copy link
Contributor Author

Yes, the CI really should be building more than it currently is. At the very least, crucible-jvm seems like a sensible thing to include in the CI. See #634.

langston-barrett added a commit that referenced this issue Oct 29, 2021
@langston-barrett
Copy link
Contributor

crucible-jvm is fixed, I'll do crucible-go next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants