Allow building with base-4.17.* (GHC 9.4.*) #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kquick
approved these changes
Jan 4, 2023
RyanGlScott
added a commit
to GaloisInc/what4
that referenced
this pull request
Jan 18, 2023
This contains a varity of changes needed to make the libraries in the `what4` repo compile with GHC 9.4: * GHC 9.4 is pickier about undecidable instance checking. See [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=24540b698481cf2b0bd11029b58eaddc0fbfbb31#stricter-undecidableinstances-checking) of the GHC 9.4 Migration Guide. As a result, I had to explicitly enable `UndecidableInstances` in `What4.Utils.AbstractDomains` to make it compile. * `ST` no longer has a `MonadFail` instance. See [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=b60e52482a666d25638d59cd7e86851ddf971dc1#st-is-no-longer-an-instance-of-monadfail) of the GHC 9.4 Migration Guide. To adapt to this change, I removed the `MonadFail` instance for `VarRecorder`, which was built on top of `ST`'s `MonadFail` instance. Accordingly, all uses of `fail` at type `VarRecorder` have now been replaced with `error`. * I bumped the `aig` submodule to bring in the changes from GaloisInc/aig#13, which are required to make `aig` build with GHC 9.4. * I bumped the upper version bounds of various dependencies to allow them to build with GHC 9.4. Fixes #224.
RyanGlScott
added a commit
to GaloisInc/what4
that referenced
this pull request
Jan 23, 2023
This contains a varity of changes needed to make the libraries in the `what4` repo compile with GHC 9.4: * GHC 9.4 is pickier about undecidable instance checking. See [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=24540b698481cf2b0bd11029b58eaddc0fbfbb31#stricter-undecidableinstances-checking) of the GHC 9.4 Migration Guide. As a result, I had to explicitly enable `UndecidableInstances` in `What4.Utils.AbstractDomains` to make it compile. * `ST` no longer has a `MonadFail` instance. See [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=b60e52482a666d25638d59cd7e86851ddf971dc1#st-is-no-longer-an-instance-of-monadfail) of the GHC 9.4 Migration Guide. To adapt to this change, I removed the `MonadFail` instance for `VarRecorder`, which was built on top of `ST`'s `MonadFail` instance. Accordingly, all uses of `fail` at type `VarRecorder` have now been replaced with `error`. * I bumped the `aig` submodule to bring in the changes from GaloisInc/aig#13, which are required to make `aig` build with GHC 9.4. * I bumped the upper version bounds of various dependencies to allow them to build with GHC 9.4. Fixes #224.
RyanGlScott
added a commit
to GaloisInc/what4
that referenced
this pull request
Jan 23, 2023
This contains a varity of changes needed to make the libraries in the `what4` repo compile with GHC 9.4: * GHC 9.4 is pickier about undecidable instance checking. See [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=24540b698481cf2b0bd11029b58eaddc0fbfbb31#stricter-undecidableinstances-checking) of the GHC 9.4 Migration Guide. As a result, I had to explicitly enable `UndecidableInstances` in `What4.Utils.AbstractDomains` to make it compile. * `ST` no longer has a `MonadFail` instance. See [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=b60e52482a666d25638d59cd7e86851ddf971dc1#st-is-no-longer-an-instance-of-monadfail) of the GHC 9.4 Migration Guide. To adapt to this change, I removed the `MonadFail` instance for `VarRecorder`, which was built on top of `ST`'s `MonadFail` instance. Accordingly, all uses of `fail` at type `VarRecorder` have now been replaced with `error`. * I bumped the `aig` submodule to bring in the changes from GaloisInc/aig#13, which are required to make `aig` build with GHC 9.4. * I bumped the upper version bounds of various dependencies to allow them to build with GHC 9.4. Fixes #224.
RyanGlScott
added a commit
to GaloisInc/crucible
that referenced
this pull request
Mar 28, 2023
This contains a variety of tweaks needed to make the libraries in the `crucible` repo build with GHC 9.4: * `ST` no longer has a `MonadFail` instance. See [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=b60e52482a666d25638d59cd7e86851ddf971dc1#st-is-no-longer-an-instance-of-monadfail) of the GHC 9.4 Migration Guide. To adapt to this change, I had to change some uses of `fail` to `error`, and I also had to avoid some partial pattern matches in `do`-notation to avoid incurring `MonadFail (ST s)` constraints. * The `aig` submodule was bumped to bring in the changes from GaloisInc/aig#13, which allows it to build with GHC 9.4. * Various upper version bounds were raised.
RyanGlScott
added a commit
to GaloisInc/crucible
that referenced
this pull request
Apr 3, 2023
This contains a variety of tweaks needed to make the libraries in the `crucible` repo build with GHC 9.4: * `ST` no longer has a `MonadFail` instance. See [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=b60e52482a666d25638d59cd7e86851ddf971dc1#st-is-no-longer-an-instance-of-monadfail) of the GHC 9.4 Migration Guide. To adapt to this change, I had to change some uses of `fail` to `error`, and I also had to avoid some partial pattern matches in `do`-notation to avoid incurring `MonadFail (ST s)` constraints. * The `aig` submodule was bumped to bring in the changes from GaloisInc/aig#13, which allows it to build with GHC 9.4. * Various upper version bounds were raised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.