deps: make socks and serial optional

[Arusekk]

No description provided.

[peace-maker]

Do you want to remove them from the required packages in the pyproject.yml too? Maybe move them to a "all" group or similar?
https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#optional-dependencies

[Arusekk]

Yes, that would be great, to make most heavy deps actually install-time optional, not only runtime-optional. If possible, I would like to move there (apart from pysocks and pyserial): rpyc, requests, unicorn, capstone, colored_traceback and paramiko.

[peace-maker]

This appears to render the following code useless, since a ProxyError is not a socket.error?

[Arusekk]

This is a bit tricky, so I am not sure I got it right:

• We want to reraise all socks.ProxyErrors. We also want to silence all socket.errors (not sure why, but w/e, this is what the code has been doing so far).
• On py2 socket.error is a child class of IOError, which is also the base class for socks.ProxyError. Therefore the following code is useless indeed.
• On py3 socket.error is a deprecated alias for OSError, which is also aliased as IOError, and is therefore the base class for socks.ProxyError. The first check will always fail (so not sure whether we want to keep it), so the second check for socks.ProxyError is still needed, although I think we could also get away without importing socks, but through inspecting the exception's __mro__ for classes matching c.__module__ == "socks" and c.__name__ == "ProxyError". This is not an expensive import however, and an error path anyway, so I think we can afford some extra time spent during actually importing the module.

Another idea I have is to cache the last exception anyway, and raise it just as socket.create_connection does. And I think this will be the best way in the end.

[peace-maker]

Hm, we should log the pip install pwntools[full] command and the exact missing library in the error message when users try to use such a feature.

To avoid confusion with the change of pip install pwntools not installing everything.

[Arusekk]

I would prefer pwntools[slim] to be without features, but it seems optional dependencies can only be positive. Email z poniedziałku 21 sierpnia 2023 od peace-makera:

…

Hm, we should log the `pip install pwntools[full]` command and the exact missing library in the error message when users try to use such a feature. To avoid confusion with the change of `pip install pwntools` not installing everything. -- Reply to this email directly or view it on GitHub: #2245 (comment) You are receiving this because you authored the thread. Message ID: ***@***.***

-- Wysłane z mojego urządzenia Sailfish

[peace-maker]

The typer package now provides a typer-slim package which doesn't contain heavy dependencies.
https://github.com/tiangolo/typer?tab=readme-ov-file#typer-slim

Maybe that is an option.

[Arusekk]

Okay, maybe it would be doable, but not in this release. I would be happy to already have the deps de facto optional (i.e. pwntools not breaking if something from this list is missing) though.