-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buxfix: set autocomplete attribute to api-key input #1024
buxfix: set autocomplete attribute to api-key input #1024
Conversation
这个方法确实有用欸,把 API-Key 的自动填充属性改掉,模型选择这边也不显示了 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
似乎真的有用
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
似乎确实有用,但我不理解为什么改API key的反而使得这里model-select-dropdown的提示消失……是因为原先apikey input的autocomplete属性没有值吗?我不理解……之前直接设置model-select-dropdown的input的autocomplete值为new-password就不行……
代码或者pr title确实得改一下
update
我懂了,chrome把apikey的位置当成了密码栏,model selected dropdown的位置当成了用户名栏……
还是off,确实没生效,这怎么回事呀 |
@FreedomXD 确定拉取了最新的代码吗?或者我们这几天release一个新版本,应该就没问题了 |
是最新的,我还进去看了代码,不知道咋回事 |
那其他的js能生效吗?控制台有其他报错吗?那些按钮能按吗? |
看起来都是生效的,没有太多额外的报错,然后可见范围内的按钮都能按,我再查一下吧,不行就等你们的新版本release |
@FreedomXD 我这边本地确认了,没有问题。autocomplete 属性能生效。 请确认本地代码仓库中已经包含这个 pr 的改动。 |
好的我确认一下,谢谢 |
作者自述
描述
使用 new-password 作为 autocompletion 属性的值,以避免 chrome 显示密码自动提示框。
https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#preventing_autofilling_with_autocompletenew-password
before:
after:
相关问题
#1020