RenderPassEditor : Support registering columns with a specific index #6219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A-maze-ing. This will really help with some of the usability Qs we've had of late. Many thanks @murraystevenson 🙏 |
Columns are usually displayed in the order that they are registered. This change allows custom columns registered after Gaffer's standard columns to be displayed ahead of or intermixed within Gaffer's standard columns. `index` specifies the column's position to the right of the "Active" column, as we consider the "Name" and "Active" columns to be a primary part of the editor with fixed positions. A negative index can be used to position a column at the end of the list. If multiple columns are registered with the same index, they are ordered within that index based on their registration order. So if columns A and B are both registered with an index of -1, they will appear as the rightmost columns, with B positioned after A as it was registered second.
johnhaddon
force-pushed
the
renderPassEditorColumnIndex
branch
from
a786435 to
5ac2886
Compare
|
Thanks Murray! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Columns are usually displayed in the order that they are registered. This change allows custom columns registered after Gaffer's standard columns to be displayed ahead of or intermixed with Gaffer's standard columns.
indexspecifies the column's position to the right of the "Active" column, as we consider the "Name" and "Active" columns to be a primary part of the editor with fixed positions.A negative index can be used to position a column at the end of the list. If multiple columns are registered with the same index, they are ordered within that index based on their registration order. So if columns A and B are both registered with an index of -1, they will appear as the rightmost columns, with B positioned after A as it was registered second.