Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Subdiv Options in MeshTessellate #5804

Merged

Conversation

danieldresser-ie
Copy link
Contributor

This hooks up the new properties made in: ImageEngine/cortex#1413, so that they can be set by MeshType, and read by MeshTessellate.

I realized one thing we haven't talked about that could be considered necessary for this to be considered complete is hooking these properties up to various renderers. If you can set it using MeshType, that kind of implies that we should try to respect that when passing the mesh to the renderer - Arnold only supports 4 of the 6 options for one of these parameters, and appears to have no support for the other two, but I guess we could at least pass through what does match?

@danieldresser-ie
Copy link
Contributor Author

While doing some last minute double checking, realized that I hadn't correctly handled indexed constant primvars in the original tessellateMesh PR ... I had test data for it generalTestMesh.usd, but I'd neglected to actually check the result for this case in the reference file I made. Fixed now.

Copy link
Member

@johnhaddon johnhaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel! I've noted a few typos and suggested a different plug ordering, but otherwise LGTM. Feel free to just squash any fixes straight it.

I've also updated my dependencies PR to include the Cortex version needed for this PR. Would be good to get some eyes on that today if we can @murraystevenson.

python/GafferSceneUI/MeshTypeUI.py Outdated Show resolved Hide resolved
python/GafferSceneUI/MeshTypeUI.py Outdated Show resolved Hide resolved
python/GafferSceneUI/MeshTypeUI.py Outdated Show resolved Hide resolved
python/GafferSceneUI/MeshTessellateUI.py Outdated Show resolved Hide resolved
python/GafferSceneUI/MeshTessellateUI.py Outdated Show resolved Hide resolved
python/GafferSceneUI/MeshTessellateUI.py Outdated Show resolved Hide resolved
src/GafferScene/MeshTessellate.cpp Outdated Show resolved Hide resolved
@murraystevenson
Copy link
Contributor

I've also updated my dependencies PR to include the Cortex version needed for this PR. Would be good to get some eyes on that today if we can @murraystevenson.

Dependencies update is ready to go in #5808.

@danieldresser-ie
Copy link
Contributor Author

Fixed spelling errors, changed plug order, and squashed.

@johnhaddon
Copy link
Member

Fixed spelling errors, changed plug order, and squashed.

Sorry, just one more thing - this needs to target 1.4_maintenance rather than main.

@danieldresser-ie danieldresser-ie changed the base branch from main to 1.4_maintenance April 22, 2024 19:53
@murraystevenson
Copy link
Contributor

Thanks Daniel! Tests are passing with the latest dependencies in place. Merging.

@murraystevenson murraystevenson merged commit 9af2913 into GafferHQ:1.4_maintenance Apr 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants