cabal: Also increase transformers version in the tests#19
Merged
Gabriella439 merged 2 commits intoGabriella439:mainfrom Oct 1, 2024
Merged
cabal: Also increase transformers version in the tests#19Gabriella439 merged 2 commits intoGabriella439:mainfrom
Gabriella439 merged 2 commits intoGabriella439:mainfrom
Conversation
The library component has transformers <0.7 but the test-suite component had transformers <0.6.
Owner
|
Yes, I usually do that for my other packages already. The only reason that I'd accept a PR to remove those test bounds |
Some build-depends of the test-suite component already have their version bounds constrained by the library component, so remove those bounds to ease maintenance.
Contributor
Author
|
OK done, thanks @Gabriella439. |
Owner
|
You're welcome! Also, thank you! I published a matching revision to Hackage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library component has transformers <0.7 but the test-suite component had transformers <0.6.
I was wondering, would it be better to remove version bounds from every
build-dependsin thetest-suiteandexecutablecomponents where:librarycomponent also has that library as abuild-depends, andlibrarycomponent, andtest-suiteorexecutablehas a dependency on thelibrarycomponent.Thanks