Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chromatic Glass Crystal #1149

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Add Chromatic Glass Crystal #1149

merged 4 commits into from
Jan 15, 2025

Conversation

Nockyx
Copy link
Contributor

@Nockyx Nockyx commented Jan 11, 2025

This PR adds Chromatic Glass Gems; Normal, Flawless and Exquisite.
image
These will be used in the Infinity Line.

The Material System that Chromatic Glass is created with doesn't support gem generation inside GT5u and i couldn't get it to work there. So decided to add it in coremod, alongside the already existing lens. Just as it is done with Mysterious Crystal.

@Dream-Master Dream-Master requested a review from a team January 11, 2025 14:33
@Dream-Master
Copy link
Member

have this items any use or you planing something @Nockyx

@Nockyx
Copy link
Contributor Author

Nockyx commented Jan 11, 2025

have this items any use or you planing something @Nockyx

These will be used in the Infinity Line.

These Crystals will be made and used within the Infinity rework that is planned https://discord.com/channels/181078474394566657/1307066387096666242

@Ethryan
Copy link
Contributor

Ethryan commented Jan 11, 2025

Hmm, Maybe reduce the amount of coloring a tad, or fix the coloring of the gems, since the flawless gem looks a lot more like a lens.
Since the gem lines are almost hidden on that one.

Dream-Master and others added 2 commits January 12, 2025 12:08
# Conflicts:
#	src/main/java/com/dreammaster/gthandler/GT_Loader_Items.java
@serenibyss serenibyss enabled auto-merge (squash) January 15, 2025 06:55
@serenibyss serenibyss merged commit 623800a into master Jan 15, 2025
4 checks passed
@serenibyss serenibyss deleted the Chromatic-Glass-Gem branch January 15, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants