Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server incompatibility, add messaging for rain variable #21

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

Kortako
Copy link

@Kortako Kortako commented Jun 30, 2024

This should fix the IGI mod becoming client-side only as of v2.8.7, which caused the mod to crash if installed on a server, thus breaking any server provided information (which at the moment is only world seed and rain time, but others can be added if desired).

This is IMO a better fix for GTNewHorizons/GT-New-Horizons-Modpack#16572, as such I would recommend removing the port checks in the XML config for local vs remote servers, and just keep the info in the XML the same between SP and MP servers with this fix.

… for NextRain variable so that it works properly on both SP and MP servers
@Dream-Master Dream-Master requested a review from a team June 30, 2024 15:25
@Dream-Master
Copy link
Member

This should fix the IGI mod becoming client-side only as of v2.8.7, which caused the mod to crash if installed on a server, thus breaking any server provided information (which at the moment is only world seed and rain time, but others can be added if desired).

This is IMO a better fix for GTNewHorizons/GT-New-Horizons-Modpack#16572, as such I would recommend removing the port checks in the XML config for local vs remote servers, and just keep the info in the XML the same between SP and MP servers with this fix.

so i need to revert the pr GTNewHorizons/GT-New-Horizons-Modpack#16572 ?

@Kortako
Copy link
Author

Kortako commented Jun 30, 2024

This should fix the IGI mod becoming client-side only as of v2.8.7, which caused the mod to crash if installed on a server, thus breaking any server provided information (which at the moment is only world seed and rain time, but others can be added if desired).
This is IMO a better fix for GTNewHorizons/GT-New-Horizons-Modpack#16572, as such I would recommend removing the port checks in the XML config for local vs remote servers, and just keep the info in the XML the same between SP and MP servers with this fix.

so i need to revert the pr GTNewHorizons/GT-New-Horizons-Modpack#16572 ?

Yes, or have @PlayfulPiano modify it to add the time back in and remove the server checks. I'm not sure if they added new text otherwise, so I wouldn't want their work to go to waste.

@PlayfulPiano
Copy link

This should fix the IGI mod becoming client-side only as of v2.8.7, which caused the mod to crash if installed on a server, thus breaking any server provided information (which at the moment is only world seed and rain time, but others can be added if desired).
This is IMO a better fix for GTNewHorizons/GT-New-Horizons-Modpack#16572, as such I would recommend removing the port checks in the XML config for local vs remote servers, and just keep the info in the XML the same between SP and MP servers with this fix.

so i need to revert the pr GTNewHorizons/GT-New-Horizons-Modpack#16572 ?

Yes, or have @PlayfulPiano modify it to add the time back in and remove the server checks. I'm not sure if they added new text otherwise, so I wouldn't want their work to go to waste.

iirc the only real addition in that PR was the whole server check, but I think I also saw some in code formatting errors that didn't seem to impact raintime check functionality but didn't format consistently.

probably the best idea would be to remove the server check from the current file and implement the compatibility fix without reverting.

@Dream-Master Dream-Master merged commit 4b4105d into GTNewHorizons:master Aug 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants