-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix excessive catalyst usage during convergence if subticking #3925
Fix excessive catalyst usage during convergence if subticking #3925
Conversation
src/main/java/gregtech/common/tileentities/machines/multi/MTEPlasmaForge.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There might be a bit of a misunderstanding here, recipeDuration does take overclocks into account, in line 1023, and the calculation does yield the correct amount of catalyst even with sub-1-tick OCs
Are you sure about that? It looks to me like the calculation happens later. Regardless, it definitely shouldn’t have that subtick multiplier—subticks don’t mean more work is being done. They just ensure that work isn’t lost due to Minecraft’s tick limitations. |
src/main/java/gregtech/common/tileentities/machines/multi/MTEPlasmaForge.java
Outdated
Show resolved
Hide resolved
…lasmaForge.java Co-authored-by: GDCloud <[email protected]>
Resolves Convergence using too much catalyst on recipes that dont use catalyst before when using batch mode #18900.