Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix excessive catalyst usage during convergence if subticking #3925

Merged
merged 8 commits into from
Feb 10, 2025

Conversation

Vlamonster
Copy link
Contributor

@Dream-Master Dream-Master requested a review from a team February 10, 2025 10:27
@Dream-Master Dream-Master added the bug fix Fix a bug. Please link it in the PR. label Feb 10, 2025
Copy link
Member

@GDCloudstrike GDCloudstrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a bit of a misunderstanding here, recipeDuration does take overclocks into account, in line 1023, and the calculation does yield the correct amount of catalyst even with sub-1-tick OCs

@Vlamonster
Copy link
Contributor Author

There might be a bit of a misunderstanding here, recipeDuration does take overclocks into account, in line 1023, and the calculation does yield the correct amount of catalyst even with sub-1-tick OCs

Are you sure about that? It looks to me like the calculation happens later. Regardless, it definitely shouldn’t have that subtick multiplier—subticks don’t mean more work is being done. They just ensure that work isn’t lost due to Minecraft’s tick limitations.

@Dream-Master Dream-Master requested review from GDCloudstrike and a team February 10, 2025 21:02
@Dream-Master Dream-Master enabled auto-merge (squash) February 10, 2025 21:25
@Dream-Master Dream-Master merged commit 64c57f1 into GTNewHorizons:master Feb 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fix a bug. Please link it in the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convergence using too much catalyst on recipes that dont use catalyst before when using batch mode
3 participants