Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Old GT++ UI from some multiblocks #3819

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Remove Old GT++ UI from some multiblocks #3819

merged 2 commits into from
Jan 17, 2025

Conversation

Nockyx
Copy link
Contributor

@Nockyx Nockyx commented Jan 16, 2025

Makes so that some multiblocks which still had the old uis use the modern one.
image
-->
image

@Nockyx Nockyx added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Jan 16, 2025
@Dream-Master Dream-Master requested a review from a team January 16, 2025 21:34
@HoleFish
Copy link
Contributor

why not all of them?

@Nockyx
Copy link
Contributor Author

Nockyx commented Jan 16, 2025

why not all of them?

these are all i found, did i miss any?

@HoleFish
Copy link
Contributor

power sub at least. besides the related unused ui codes should be removed together

@Nockyx
Copy link
Contributor Author

Nockyx commented Jan 17, 2025

power substantion uses the method but it has modifications, i was going to remove but actually if has a custom ui.
image

the other one is fusion reactor, which uses the method for that custom ui
image

i don't know if these are in the same group as these 4, i think it would be out of the scope of this pr to refactor all this.

@HoleFish
Copy link
Contributor

I thought you mean all old gt++ ui?

Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know if these are in the same group as these 4, i think it would be out of the scope of this pr to refactor all this.

I agree that these are a larger work. Since this PR has a good effect on in-game experience, I'd rather merge it now and do the others later than do all of them at once

@serenibyss serenibyss merged commit 3760928 into master Jan 17, 2025
5 checks passed
@serenibyss serenibyss deleted the remove-gtpp-ui branch January 17, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants