Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated render classes #3773

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

serenibyss
Copy link
Member

Migrates all the loose ends to TextureFactory.

Also has the side effect of giving glow textures to the Atmospheric Cleaner and Auto-Chisel (singleblocks).

I checked the organization with github search and did not see any further usages of these now removed classes.

@serenibyss serenibyss requested a review from a team January 10, 2025 01:04
@serenibyss serenibyss added the refactor For PRs rewritting a part of the code to have a nicer code overall. label Jan 10, 2025
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 11, 2025
@RecursivePineapple
Copy link
Contributor

It looks like the GT++ ores are causing double-tesselation-draw issues. I'm not sure why it's only happening for some people, but it looks like src/main/java/gtPlusPlus/core/client/renderer/CustomOreBlockRenderer.java:250 conflicts with src/main/java/gregtech/common/render/GTTextureBase.java:18. The interesting thing is that GTTextureBase has a check to prevent exactly this from happening, so I'm not sure what's causing this. Maybe something to do with the angelica capturing tessellator? Regardless, the GT ISBRH doesn't call Tessellator.draw when rendering inventory blocks, so I think they should be removed from the GT++ ore ISBRH. I tested the following patch and while I couldn't reproduce the problem, it didn't break anything.

tessellator.txt

Alternatively, you could yoink my rendering changes from my ore PR which removes the GT++ and BW ISBRHs entirely (though it isn't in a specific commit, so you'd need to find each change any copy it).

Copy link
Contributor

@RecursivePineapple RecursivePineapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't add a suggested changes since you haven't edited CustomOreBlockRenderer, but I've confirmed that the above patch fixes the rendering issues with gt++ ores. The ores are causing crashes and severe lag in AE terminals (likely due to caught exceptions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta refactor For PRs rewritting a part of the code to have a nicer code overall.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants