Isolator crash fix revision

[Astatine5985]

More consistent fix for the issue: GTNewHorizons/GT-New-Horizons-Modpack#17636

Problem: extracting genes in the isolator has a chance to cause NPE leading to a server crash

Cause: some logics were changed in IsolatorComponentLogic.java from this commit 39fe5d0
This results in the possibility of NPE by removing the try-catch statement.
Which was necessary because chromosomes objects in forestry. core. genetics Genome class contains null

Proposed Solution: check whether chromosomes is null before getting the allele, and loop until it isn't null

The previous fix, #55, returns right away when it comes across NPE instead of looping back to get a non-null gene, which makes the player wait for another cycle to get the isolated gene. Which is different from the original behavior.
This solution accounts for this so that the behavior of the isolator is consistent before being broken by the above commit.

[serenibyss]

Is it possible for all chromosomes to be null here, causing an infinite loop?

[Astatine5985]

It would be impossible for normal playthrough.
If all chromosomes are null it means that the bee doesn't even have a species on them. So, i wouldn't see anyone puting a blank bee in the isolator nor obtaining them.
Nonetheless, I think it would be nice to have a some kind of way to prevent an infinite loop. Incase someone puts a blank bee for debbuging purpose.

[serenibyss]

How about something like this?

List<IChromosomeType> chromosomes = Arrays.stream(karyo)
    .filter(Objects::nonNull)
    .collect(Collectors.toList());
if (chromosomes.isEmpty()) return;
IChromosomeType chromosome = chromosomes.get(rand.nextInt(chromosomes.size()));

[Astatine5985]

karyo is a list that contains the chromosome types (SPECIES, PRODUCTION, HUMIDITY etc)

So, if we change this part of line 1
Arrays.stream(karyo)
to
Arrays.stream(individual.getGenome().getChromosomes())

And maybe change the last line too accordingly

So if we fix that part it would be a much better solution : D

• I'm on my phone so excuse me for poor formatting.