Yeet custom config in favor of NHLib #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passes the scream test, at least without binnie-specific tests
Although I'm not sure that child mods are handled correctly.
Needs testing in prod
We don't support disabling parts
|
I'd merge this after 2.7 as it doesn't fix any known bugs (as far as I'm aware) and can potentially introduce new ones. |
boubou19
added
the
ongoing freeze - do not merge
Dream-Master
removed
the
ongoing freeze - do not merge
serenibyss
reviewed
Dec 22, 2024
serenibyss
added a commit
to GTNewHorizons/GT-New-Horizons-Modpack
that referenced
this pull request
Dec 29, 2024
serenibyss
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only need one cursed extension of forge's config in this pack.
This shouldn't change any behavior - however, it completely ignores the prior configs and replaces them with two,
config/ExtraTrees.cfgandconfig/ExtraBees.cfg.The module enable/disables have been completely removed as we do not support that, and various config other files/options were removed as they were either unused in code or empty.
Some config options now work, as previously they were disconnected for no apparent reason.