Minor cleanups #50
Merged
Minor cleanups #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also enable Jabel and generic injection
OneEyeMaker
requested changes
Sep 24, 2024
There was a problem hiding this comment.
- Please apply my suggestions and corrections to all files. There are too many similar code pieces and I don't want create a mess by marking every one of them.
- Be careful with changing access modifiers of class members: some of these can be used in other mods. Please test your version of the mod in full pack (on large base with lots of machines from Binnie) to ensure everything works properly.
src/main/java/binnie/genetics/machine/isolator/IsolatorComponentLogic.java
Outdated
Show resolved
Hide resolved
src/main/java/binnie/core/craftgui/minecraft/control/EnumHighlighting.java
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ah-OOG-ah
force-pushed
the
minor-fixes
branch
from
49585a9 to
9ff3409
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I think I got most of the comments - if I missed any, please re-request changes. I haven't scream tested this in the beta yet, will update once I do. Edit: scream test passed (nightly 667 boots fine with it), although I haven't found anyone using Binnie to test it yet |
This comment was marked as outdated.
This comment was marked as outdated.
My IDE was fighting with it
ah-OOG-ah
force-pushed
the
minor-fixes
branch
from
65e4149 to
9594c9a
Compare
OneEyeMaker
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scattershot of cleanups over the codebase, almost none of them should cause changes in behavior. Exceptions:
IsolatorComponentLogica try-catch was removed