-
Notifications
You must be signed in to change notification settings - Fork 34
Fix cf-cli download URL to use direct GitHub release URL #1931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -121,16 +121,17 @@ jobs: | |
| mkdir /tmp/test-results | ||
| TEST_FILES="$(circleci tests glob "spec/**/*_spec.rb" | circleci tests split --split-by=timings)" | ||
|
|
||
| bundle exec rspec --format progress \ | ||
| --format RspecJunitFormatter \ | ||
| --out /tmp/test-results/rspec.xml \ | ||
| --format progress \ | ||
| $TEST_FILES | ||
| bundle exec rspec --format progress \ | ||
| --format RspecJunitFormatter \ | ||
| --out /tmp/test-results/rspec.xml \ | ||
| --format progress \ | ||
| $TEST_FILES | ||
| # Install Cloud Foundry cli (cf) before deploy step. cf is used to push to Cloud.gov | ||
| - run: | ||
| name: Install-cf-cli | ||
| command: | | ||
| curl -v -L -o cf-cli_amd64.deb 'https://packages.cloudfoundry.org/stable?release=debian64&source=github' | ||
| # Install latest cf8 CLI release (keeps minor/patch versions up to date) | ||
| curl -L -o cf-cli_amd64.deb 'https://github.com/cloudfoundry/cli/releases/latest/download/cf8-cli-installer_x86-64.deb' | ||
| sudo dpkg -i cf-cli_amd64.deb | ||
| cf -v | ||
| # collect reports | ||
|
|
@@ -180,7 +181,7 @@ jobs: | |
| - run: | ||
| name: Install-cf-cli | ||
| command: | | ||
| curl -v -L -o cf-cli_amd64.deb 'https://packages.cloudfoundry.org/stable?release=debian64&source=github' | ||
| curl -L -o cf-cli_amd64.deb 'https://github.com/cloudfoundry/cli/releases/download/v8.17.0/cf8-cli-installer_8.17.0_x86-64.deb' | ||
|
||
| sudo dpkg -i cf-cli_amd64.deb | ||
| cf -v | ||
| - run: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filename in the download URL appears to have an incorrect architecture format. The URL uses 'x86-64' but Debian packages for Cloud Foundry CLI typically use 'x86_64' with an underscore. Please verify this is the correct URL by checking the actual GitHub releases page at https://github.com/cloudfoundry/cli/releases/tag/v8.17.0 to ensure the filename matches exactly.