Fix cx_collections export_csv 500 error #1910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle nil organization in User#cx_collections to prevent NoMethodError - Add eager loading for service_provider.organization and cx_collection_details - Add missing database indexes on cx_collections, cx_collection_details, cx_responses Fixes the 'We're sorry, but something went wrong' error at: /admin/cx_collections/export_csv
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a 500 error in the CX collections CSV export functionality that occurred when users without an organization attempted to export data. The fix adds a nil check for user organization, improves query performance with better eager loading, and adds missing database indexes on foreign keys.
Key Changes:
- Added nil organization check in
User#cx_collectionsto return empty collection instead of raising NoMethodError - Improved eager loading in
CxCollection.to_csvto include nested associations and prevent N+1 queries - Added database indexes on foreign key columns for cx_collections, cx_collection_details, and cx_responses tables
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/models/user.rb | Added early return when user has no organization to prevent nil reference errors |
| app/models/cx_collection.rb | Enhanced eager loading with nested associations and fixed redundant variable assignment on line 124 |
| db/migrate/20251210192727_add_indexes_to_cx_collections.rb | Added missing foreign key indexes to improve query performance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The 'DOWNLOAD Collections as .csv' button at
/admin/cx_collections/export_csvreturns a 500 error ('We're sorry, but something went wrong').Root Cause
The
User#cx_collectionsmethod callsuser_org.idwithout checking ifuser_orgisnil. When a user has no organization, this throws:Solution
app/models/user.rb- Added early returnCxCollection.nonewhen user has no organizationapp/models/cx_collection.rb- Improved eager loading to includeservice_provider.organizationandcx_collection_detailsto prevent N+1 queriescx_collections,cx_collection_details, andcx_responsestables for better query performanceTesting
Related
Fixes issue reported by OMB (Bin Zheng) since Nov 19, 2025