Performance improvement for form responses #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve loading performance of 'Responses by status' table * Use S3 to store results of async export jobs
ryanwoldatwork
commented
Jul 16, 2024
ryanwoldatwork
commented
Jul 16, 2024
ryanwoldatwork
commented
Jul 16, 2024
sanason
reviewed
Jul 16, 2024
sanason
reviewed
Jul 16, 2024
| @@ -33,31 +33,5 @@ | |||
| <%= paginate @events %> | |||
|
|
|||
| <p> | |||
| <%= link_to "Export Events to CSV", admin_export_events_url(format: "csv"), class: "usa-button export-btn", target: "_blank", rel: "noopener" %> | |||
| <%= link_to "Export Events to CSV", admin_export_events_url, class: "usa-button", target: "_blank", rel: "noopener" %> | |||
There was a problem hiding this comment.
I know it's pre-existing behavior but it's kind of weird that this opens in a new tab when none of the other exports do.
sanason
reviewed
Jul 16, 2024
sanason
reviewed
Jul 16, 2024
sanason
reviewed
Jul 16, 2024
sanason
reviewed
Jul 16, 2024
| csv_content = Version.to_csv(versionable) | ||
| ActionCable.server.broadcast( |
There was a problem hiding this comment.
When I run this locally, this job fails with error:
ArgumentError: wrong number of arguments (given 1, expected 2)
sanason
reviewed
Jul 16, 2024
sanason
reviewed
Jul 16, 2024
| @@ -16,6 +18,17 @@ def notification(title: '', body: '', path: '', emails: []) | |||
| to: emails | |||
| end | |||
|
|
|||
| def async_report_notification(email:, start_time:, completion_time:, record_count:, url:) | |||
There was a problem hiding this comment.
Ryan, you mentioned making some readability improvements to the email. If you're doing that, I think it would be useful to include the name of the exported file in the email body and/or subject, unless there's some security reason not to.
There was a problem hiding this comment.
good point. i've noted this in Trello and we can follow up with feature
sanason
reviewed
Jul 16, 2024
* update filename and job options * clear form tag filter * update seeds * return all websites * ensure s3 helper has a timestamp as well * update record_count
* remove opener from export events * indicate export buttons with an icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.