Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ang 10 compat #528

Open
wants to merge 5 commits into
base: angular-10
Choose a base branch
from
Open

ang 10 compat #528

wants to merge 5 commits into from

Conversation

diego-ruiz-rei
Copy link
Contributor

Description

updates needed for angular 10 for SFE

  • convert renderer(1) to renderer2
  • picker.component.ts already extends formcontrol which has a disabled property, ivy flagged a duplicate property that wasn't used
  • expansion panel, expanded accessor now available and we don't need to track expanded state by presence of css class

Motivation and Context

Type of Change (Select One and Apply Github Label)

  • Bug fix (non-breaking change which fixes an issue) -> Apply bugfix label
  • New feature (non-breaking change which adds functionality) -> Apply enhancement label
  • Breaking change (fix or feature that would cause existing functionality to change) -> Apply breaking label

Screenshots (if appropriate):

Which browsers have you tested?

  • Internet Explorer 11
  • Edge
  • Chrome
  • Firefox
  • Safari

Checklist:

yerramshilpa and others added 5 commits October 7, 2020 17:01
@yerramshilpa
updated autocompltet (GSA#521)
020f4ba
@yerramshilpa
Autocomplete Focus out fix (GSA#522)
8d2a8fe 
* focus out changes

* updated package version
@CharanMareedu-REISys
[PR] FIX CLEAR ISSUE ON ENTER ON SAM AUTO COMPLETE (GSA#526)
bda7061 
* Update sidenav.component.ts

Adding Nav Service to Isolate Nav component with each service

* fix clear issue on autocomplete

* revert sidenav change
ang 10 compat
7673111
Merge branch 'angular-10' of https://github.com/REI-Systems/OGST-GSA-…
469e235 
…IAE-sam-ui-elements into ang-10-compat
@diego-ruiz-rei diego-ruiz-rei changed the base branch from master to angular-10 December 2, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diego-ruiz-rei @yerramshilpa @CharanMareedu-REISys