Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve AMP issues on sam-autocomplete #514

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

trandrew08
Copy link
Contributor

Description

  • Pulling in the same changes to autocomplete-search.component.html to resolve AMP issues on sam-autocomplete.
  • Per new ARIA 1.2 guidelines (which is still in drafting stage), they are acknowledging the problem and are recommending that we remove the wrapper.

aria-1 2

https://www.w3.org/TR/wai-aria-1.2/#substantive-changes-since-the-wai-aria-1-1-recommendation

Motivation and Context

Type of Change (Select One and Apply Github Label)

  • Bug fix (non-breaking change which fixes an issue) -> Apply bugfix label
  • New feature (non-breaking change which adds functionality) -> Apply enhancement label
  • Breaking change (fix or feature that would cause existing functionality to change) -> Apply breaking label

Screenshots (if appropriate):

Which browsers have you tested?

  • Internet Explorer 11
  • Edge
  • Chrome
  • Firefox
  • Safari

Checklist:

@trandrew08 trandrew08 marked this pull request as draft August 5, 2020 14:35
@trandrew08 trandrew08 marked this pull request as ready for review August 5, 2020 14:35
@trandrew08
Copy link
Contributor Author

@yerramshilpa @davereed Please review. This is making the sam-autocomplete component the same as autocomplete-search component for 508 compliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant