add debugging for sender numbers #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccostino
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Thanks, @terrazoon!
Hopefully this sheds more light on what's happening. As I see it, this should tell us the following:
- What the type is for the sender and default number (should be a
string) - Let us know if the sender is not of a
stringtype for whatever reason - If the sender is valid, explicitly log that as such
- If the sender is not valid, explicitly log that the default number is being used instead
xlorepdarkhelm
approved these changes
Nov 13, 2024
stvnrlly
approved these changes
Nov 13, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add logging to see what is going on with origination numbers
Security Considerations
N/A