reduce number of pool connections #1384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We saw some BrokenPipeErrors that caused messages not to be sent. Some of the stack traces pointed in the direction of multiprocessing.Manager, which handles downloading S3 objects to build up our jobs cache.
One recommendation when seeing BrokenPipeError is to reduce the number of connections in the connection pool, and that is the easiest fix to try.
Others are:
NOTE: The
multiprocessing.Manager
is used in app/aws/s3.py and the whole cache-building workflow also relies on concurrent.futures.ThreadPoolExecutor. Both rely on the AWS_CLIENT_CONFIG, which defines the maximum number of pool connections.Security Considerations
N/A