US-NOTIFY-COMPLY 50: Verify Nonce For Invite #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlorepdarkhelm
requested review from
ccostino,
stvnrlly,
terrazoon and
A-Shumway42
ccostino
reviewed
Oct 15, 2024
There was a problem hiding this comment.
Thanks, @xlorepdarkhelm! Only one quick question here from me that I wanted to double check on.
|
@xlorepdarkhelm it looks like this should be mostly good to go, just a few test failures to work through now! |
terrazoon
approved these changes
Oct 16, 2024
xlorepdarkhelm
temporarily deployed
to
staging
GitHub Actions
Inactive
Signed-off-by: Cliff Hill <[email protected]>
Signed-off-by: Cliff Hill <[email protected]>
xlorepdarkhelm
force-pushed
the
USN-COMPLY-50-Verify_Nonce_for_Invite
branch
from
ea36e46
to
0b648c9
Compare
xlorepdarkhelm
temporarily deployed
to
staging
GitHub Actions
Inactive
A-Shumway42
approved these changes
Oct 22, 2024
ccostino
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.
Description
Makes nonce opertions for login.gov work for invites as well as the logins now. (api side)
Issue
https://github.com/GSA/us-notify-compliance/issues/50
Security Considerations
This improves the security for logins through login.gov.
NOTE
Do not merge until GSA/notifications-admin#2024 is also ready.