Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One more attempt at fixing the Login.gov registration URL #1350

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

ccostino
Copy link
Contributor

@ccostino ccostino commented Oct 1, 2024

A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.

Description

This changeset attempts another fix by referencing the environment variable in a different fashion, according to the GitHub docs:

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#example-usage-of-the-env-context

Security Considerations

  • We're being mindful of the difference between GitHub secrets and public code.

@ccostino ccostino added engineering github_actions Pull requests that update GitHub Actions code labels Oct 1, 2024
@ccostino ccostino self-assigned this Oct 1, 2024
@ccostino ccostino merged commit dbfc025 into main Oct 1, 2024
7 checks passed
@ccostino ccostino deleted the login-gov-url-fix-again branch October 1, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering github_actions Pull requests that update GitHub Actions code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants