Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to GitHub Action container environment variable #1347

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

ccostino
Copy link
Contributor

@ccostino ccostino commented Oct 1, 2024

A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.

Description

This changeset attempts to fix another issue with the deploy command by setting and referring to an environment variable directly.

Security Considerations

  • We are being mindful of which env vars are secret vs. which are considered public with the code.

This changeset attempts to fix another issue with the deploy command by setting and referring to an environment variable directly.

Signed-off-by: Carlo Costino <[email protected]>
@ccostino ccostino added engineering github_actions Pull requests that update GitHub Actions code labels Oct 1, 2024
@ccostino ccostino self-assigned this Oct 1, 2024
Copy link
Member

@A-Shumway42 A-Shumway42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fingers crossed! Thank you @ccostino!

@ccostino ccostino merged commit 816c8e9 into main Oct 1, 2024
7 checks passed
@ccostino ccostino deleted the login-gov-url-fix branch October 1, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering github_actions Pull requests that update GitHub Actions code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants