Modify input to accepted argument #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccostino
reviewed
Sep 26, 2024
There was a problem hiding this comment.
Thanks, @A-Shumway42!
I think the change is fine (I left a comment that might help make things slightly easier to read... 😆), and it looks like the build check failing is because test coverage has dropped again. D'oh!
added 2 commits
September 30, 2024 09:24
…fix-cfcommand-deploytool
ccostino
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After switching to maintained cloudgov deploy tool, there was an unexpected argument for the tool. Updated with
cf_commandargument and added the new push command.The command I currently have seems a bit redundant in how it's written since I'm calling the secrets.ETC and the variables are being called the same way directly above. Would definitely like some input on how it should be tweaked.
Security Considerations
Make sure secrets are protected correctly in the new push command.