Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial phone validation ability #1331

Merged
merged 3 commits into from
Sep 13, 2024
Merged

add initial phone validation ability #1331

merged 3 commits into from
Sep 13, 2024

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Sep 12, 2024

Description

Users have expressed an interest in being able to check if phone numbers are landlines or mobile phones. Use pinpoint.phone_number_validate() for this. This is a proof of concept.

Security Considerations

N/A

@terrazoon terrazoon self-assigned this Sep 12, 2024
@terrazoon terrazoon linked an issue Sep 12, 2024 that may be closed by this pull request
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon; I'm curious to see how this works out!

@ccostino
Copy link
Contributor

Nice call and catch with the additional error handling, thank you! 🙂

Copy link
Member

@A-Shumway42 A-Shumway42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@terrazoon terrazoon merged commit eb736ca into main Sep 13, 2024
7 checks passed
@terrazoon terrazoon deleted the notify-api-1306 branch September 13, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create backend phone validation feature
3 participants