actually start deleting old s3 objects #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccostino
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Thank you, @terrazoon, and especially for the log statements of successful or failed activity and the notes in the test to prove out the timing of the removal!
A-Shumway42
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we added this ability in "log only" mode. On staging we can now see there are lots of old s3 objects in need of deletion and the logging seems to work properly.
Modify the code so it actually starts deleting old objects and enhance the test so it proves only old objects, and not new objects, are deleted.
Security Considerations
N/A