Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more debug for e2e tests #1313

Merged
merged 3 commits into from
Sep 4, 2024
Merged

more debug for e2e tests #1313

merged 3 commits into from
Sep 4, 2024

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Sep 4, 2024

Description

Looks like we might be raise a TypeError that gets silently suppressed. Add more debug around this to get e2e tests working with the staging backend.

Security Considerations

Remove this debug when it works.

@terrazoon terrazoon changed the title more debug more debug for e2e tests Sep 4, 2024
@terrazoon terrazoon requested review from a team, A-Shumway42 and xlorepdarkhelm and removed request for a team September 4, 2024 20:34
Copy link
Contributor

@xlorepdarkhelm xlorepdarkhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon!

@ccostino ccostino merged commit 21dd065 into main Sep 4, 2024
7 checks passed
@ccostino ccostino deleted the notify-admin-1157 branch September 4, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants