Api 1265 adding fields for template stats #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cliff Hill <[email protected]>
Signed-off-by: Cliff Hill <[email protected]>
Signed-off-by: Cliff Hill <[email protected]>
Signed-off-by: Cliff Hill <[email protected]>
xlorepdarkhelm
requested review from
ccostino,
terrazoon,
A-Shumway42 and
heyitsmebev
Signed-off-by: Cliff Hill <[email protected]>
Signed-off-by: Cliff Hill <[email protected]>
heyitsmebev
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.
Description
Adding the requested fields to the API for the template statistics report.
This also rewrites the queries to use SQLAlchemy 2.0 standards for the modified DAO function.
Ref: #1265
Security Considerations
None I can think of, these aren't protected data in the fields, and if anything, the new SQLAlchemy 2.0 standard will be more future-proof than using the old form.