Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix job.created_at time if necessary #1284

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Fix job.created_at time if necessary #1284

merged 6 commits into from
Aug 20, 2024

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Aug 20, 2024

Description

We have some anomaly where the created_at field for jobs is set 3 days in the past (intermittently). It seems like there is only one place where this happens (dao_create_job()), so add some debugging and a repair attempt and get this up to staging and see what happens.

We have a couple dozen tests using "freeze time" which all break if we try to do the repair, so do a check on what environment we are running in before doing it.

Security Considerations

N/A

@terrazoon terrazoon requested review from A-Shumway42, heyitsmebev and xlorepdarkhelm and removed request for heyitsmebev August 20, 2024 18:43
@terrazoon terrazoon marked this pull request as draft August 20, 2024 19:14
@terrazoon terrazoon marked this pull request as ready for review August 20, 2024 20:03
Copy link
Contributor

@xlorepdarkhelm xlorepdarkhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon!

@ccostino ccostino merged commit b9cfa10 into main Aug 20, 2024
7 checks passed
@ccostino ccostino deleted the notify-admin-1859 branch August 20, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants