Read over Python 3.12's Logging Guide and see if there's anything else we could be leveraging/configuring to improve how logging is structured throughout our applications #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrazoon
changed the title
|
Looks like this needs another merge from |
|
D'oh, style check fail; also PR still needs a proper description! 🙂 |
ccostino
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Awesome @terrazoon, thank you for this cleanup! This will help improve logging going forward, and nice catch with several of the older debug statements or other things that should not be logged as well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ticket consisted of reading the best practices and then changing our code to add 'excInfo=True' to most of our calls to current_app.logger.error(). By default, error() (unlike exception()) doesn't print a stack trace, but usually we want it to. Then we needed to remove some of the raise Exception as e statements where we passed e as a parameter to the logger (since we would be getting the complete stack trace).
Security Considerations
N/A