API: Consider forking remaining Gov UK dependencies #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrazoon
changed the title
|
@terrazoon we just need a quick sync with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are two remaining dependencies that come from govuk -- govuk-bank-holidays and notifications-python-client.
govuk-bank-holidays is solely used for "letter timings", whatever they are. We are not sending letters, so I have just deleted the code completely there.
notifications-python-client is integrally related to authentication of requests coming into the API side. In theory we could extract the parts we want, refactor everything, etc. But this particular package is already integrated into pypi so it hardly seems worth while. I feel it's better to treat it like any other third party package since (presumably), old versions of notifications-python-client which we might need will stay up on pypi, just like any other dependency.
Security Considerations
N/A