Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception Investigation: app.authentication.auth:AuthError #1233

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Exception Investigation: app.authentication.auth:AuthError #1233

merged 4 commits into from
Aug 2, 2024

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Aug 1, 2024 •
edited
Loading

Description

Prevent the stack trace from being dumped in the log.

Security Considerations

Prevent information disclosure

@terrazoon terrazoon self-assigned this Aug 1, 2024
@terrazoon terrazoon linked an issue Aug 1, 2024 that may be closed by this pull request
Exception Investigation: app.authentication.auth:AuthError #1135
Closed
3 tasks
@terrazoon terrazoon changed the title fix stack trace Exception Investigation: app.authentication.auth:AuthError Aug 1, 2024
@terrazoon terrazoon requested review from ccostino and a team August 1, 2024 21:49
jskinne3
jskinne3 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@jskinne3 jskinne3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the style check which wants you to format comments differently

ccostino
ccostino approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon!

@ccostino ccostino merged commit 4dcadfd into main Aug 2, 2024
7 checks passed
@ccostino ccostino deleted the notify-api-1135 branch August 2, 2024 20:47
@terrazoon terrazoon mentioned this pull request Aug 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskinne3 jskinne3 jskinne3 approved these changes

@ccostino ccostino ccostino approved these changes

Assignees

@terrazoon terrazoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception Investigation: app.authentication.auth:AuthError
3 participants
@terrazoon @ccostino @jskinne3