Getting the logging where I think it will be most useful. #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlorepdarkhelm
requested review from
ccostino,
terrazoon,
A-Shumway42 and
alexjanousekGSA
Signed-off-by: Cliff Hill <[email protected]>
xlorepdarkhelm
force-pushed
the
admin-1701_Logging_set_up_around_service_phone_numbers
branch
from
b2e7a31
to
67b43ff
Compare
Signed-off-by: Cliff Hill <[email protected]>
|
It looks like there are a few tests failing with |
terrazoon
approved these changes
Jul 23, 2024
Signed-off-by: Cliff Hill <[email protected]>
ccostino
approved these changes
Jul 24, 2024
ccostino
deleted the
admin-1701_Logging_set_up_around_service_phone_numbers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up logging for sender information. It does not contain PII for individuals, it contains information we have for the sender.