-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dead code #1101
remove dead code #1101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just wondering though, should the code be commented out or removed? We'll have the code existing in git, so wondering if we need to really keep it in the code, as commented out code tends to make things messy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going through and gathering up a few things here, @terrazoon!
I agree with @xlorepdarkhelm, let's just straight up remove it. If it's still necessary, it'll be obvious we need to keep it and we can put it back in, but let's not leave it to chance that this all continues to linger.
We also need an updated PR description with the details of the PR instead of the template, please. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @terrazoon!
Description
The Vulture tool scans for dead code. In our build process, it runs automatically, but we have tuned the confidence level to 100 percent. So if guaranteed dead code exists, the build will fail.
However, it is possible to tune Vulture down to 60 percent confidence, at which point it makes informed guesses about whether code is dead or not. With these findings, a developer has to go through and verify "yes, this code looks dead" but still it is a handy way to find questionable code.
In this PR we remove a few things that are flagged by Vulture and clearly are dead.
Security Considerations
N/A