Comma escape #1755
Draft
Comma escape #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlorepdarkhelm
requested changes
Jul 23, 2024
| @@ -956,7 +960,10 @@ def send_notification(service_id, template_id): | |||
| values = [] | |||
| for k, v in session["placeholders"].items(): | |||
| keys.append(k) | |||
| values.append(v) | |||
| print(hilite(f"value: {v} type: {type(v)}")) | |||
| value_quotes = '"' + v + '"' | |||
There was a problem hiding this comment.
value_quotes = f'"{v}"'
Would be more efficient/cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change adding quotes to the values that users enter when sending a one-off. These values will go to the api intact with any commas. However, the issue in the api PR still needs to be addressed to figure out why the text message isn't going through.