Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix odp ID for SI-03 (issue#695) #714

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

Rene2mt
Copy link
Member

@Rene2mt Rene2mt commented Sep 23, 2024

Committer Notes

This PR fixes the ODP bug identified in issue #695.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Rene2mt Rene2mt added the bug Something isn't working label Sep 23, 2024
@Rene2mt Rene2mt requested a review from a team as a code owner September 23, 2024 20:40
More details about GHA runner compatibility with old versus new docker
compose commands in this discussion post.

https://github.com/orgs/community/discussions/27185
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the unrelated cherry pick (even though it breaks tests), thanks so much for quickly tightening this up and fix the parameter.

@aj-stein-gsa aj-stein-gsa merged commit 8c539cf into GSA:master Sep 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants