Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inventory-item-and-component-has-public Constraint #1050

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

Gabeblis
Copy link
Contributor

Committer Notes

Purpose

This PR aims to add the inventory-item-and-component-has-public constraint which helps determine if every inventory item or internal service component is public facing by providing that information in the "public" prop.

Changes

Added constraint:

  • inventory-item-and-component-has-public

Added valid/invalid test content:

  • ssp-inventory-item-and-component-has-public-INVALID.xml
  • Edited fedramp-ssp-example.oscal.xml to align with constraint

Added yaml files for testing:

  • Pass/fail yaml tests added for each of the above constraints.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Dec 30, 2024
@Gabeblis Gabeblis requested a review from a team as a code owner December 30, 2024 15:02
@Gabeblis Gabeblis linked an issue Dec 30, 2024 that may be closed by this pull request
16 tasks
@Gabeblis Gabeblis force-pushed the constraints/issue-1028 branch from a238353 to bf1d63a Compare December 30, 2024 15:04
@Gabeblis Gabeblis changed the title Add inventory-item-and-component-has-public-property Constraint Add inventory-item-and-component-has-public Constraint Dec 30, 2024
@Gabeblis Gabeblis force-pushed the constraints/issue-1028 branch from bf1d63a to 06ef861 Compare December 30, 2024 15:06
wandmagic
wandmagic previously approved these changes Dec 30, 2024
Copy link

@wandmagic wandmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and simple one

@wandmagic wandmagic merged commit 0e2ce18 into GSA:develop Dec 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory - Public Facing Item
3 participants