Skip to content

Add additional information to country support table#709

Merged
zachmargolis merged 5 commits intomargolis-country-supportfrom
margolis-add-dialing-code
Oct 22, 2021
Merged

Add additional information to country support table#709
zachmargolis merged 5 commits intomargolis-country-supportfrom
margolis-add-dialing-code

Conversation

@zachmargolis
Copy link
Copy Markdown
Contributor

We have some additional data that we could render, but may be one of those "just be cause you can doesn't mean you should kind of things", so I'm just throwing this out there as a possibility

  • I feel like having country code could be useful for viewing this page in other languages, because currently the country names are untranslated
  • Same with dialing code? Could be useful but isn't needed.

We could make these separate columns in the table if we wanted, but I worry that would add even more visual noise.

Screen Shot 2021-10-22 at 2 05 21 PM

@nickttng
Copy link
Copy Markdown
Contributor

nickttng commented Oct 22, 2021

I feel like having country code could be useful for viewing this page in other languages, because currently the country names are untranslated

The ISO country code could be useful in the meantime (until we improve the translation experience).

Same with dialing code? Could be useful but isn't needed

Could you share why you think it isn't needed? Does listing ISO country code suffice?

We could make these separate columns in the table if we wanted, but I worry that would add even more visual noise.

If including dialing codes, at least consider having those in a separated column. In this case, I think it'd be helpful to have them described explicitly. Also, from a screen reader user standpoint, I think receiving a dialing code number without any context to anchor it might be confusing to them.

@zachmargolis
Copy link
Copy Markdown
Contributor Author

Same with dialing code? Could be useful but isn't needed

Could you share why you think it isn't needed? Does listing ISO country code suffice?

In my mind for the typical workflow to see if a country is supported, I would just try to cmd-f by the country name, falling back to the abbreviation, typically I don't refer to the dialing code. But maybe somebody else would?

@nickttng
Copy link
Copy Markdown
Contributor

But maybe somebody else would?

Hmm, for a French or Spanish user in this case, is it the translation experience reliable w/r/t country code? If not, could there be cases where dialing code might be helpful here?

@zachmargolis
Copy link
Copy Markdown
Contributor Author

But maybe somebody else would?

Hmm, for a French or Spanish user in this case, is it the translation experience reliable w/r/t country code? If not, could there be cases where dialing code might be helpful here?

It probably wouldn't hurt to add it. One issue is that sometimes countries share a dialing code (ex both the US and Canada use +1)

Also for reference here is AWS Pinpoint's page with a similar table, they include dialing code: https://docs.aws.amazon.com/pinpoint/latest/userguide/channels-sms-countries.html

@zachmargolis
Copy link
Copy Markdown
Contributor Author

Updated to have dialing code in its own column (06baa4b)

Screen Shot 2021-10-22 at 2 40 27 PM

@nickttng
Copy link
Copy Markdown
Contributor

Looking to be in the right direction. 👍🏼

@zachmargolis
Copy link
Copy Markdown
Contributor Author

Cool! Will merge to include this in the main PR

@zachmargolis zachmargolis merged commit 5a7d4b0 into margolis-country-support Oct 22, 2021
@zachmargolis zachmargolis deleted the margolis-add-dialing-code branch October 22, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants