Add support for URL locale filter to target specific locale#676
Merged
Conversation
Contributor
|
Spec failure seems like we ate the wrong part of a URL |
Contributor
Contributor
Author
Nice, thanks for giving it a look. I'd put together a spec file toward the end of the day on Friday and it looks like your changes work well 👍 Pushed a few other changes as well. |
zachmargolis
approved these changes
Jul 12, 2021
Comment on lines
+1
to
+4
| require 'jekyll' | ||
| require './_plugins/locale_url_filter.rb' | ||
|
|
||
| class JekyllFilter |
**Why**: To simplify language picker URL logic Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
aduth
force-pushed
the
aduth-locale-url-filter-target
branch
from
052d26d to
b7d1c0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #674 (comment)
Why: To simplify language picker URL logic.