Skip to content

Don't use import.meta.dirname in webpack.config.js #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthinz merged 2 commits into from
Oct 1, 2024
Merged

Don't use import.meta.dirname in webpack.config.js #1341

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82d89a0
Don't use import.meta.dirname
matthinz Oct 1, 2024
884673d
Update variable name to appease linter
matthinz Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
const { NODE_ENV = 'production' } = process.env;
import { dirname } from 'node:path';
import { fileURLToPath } from 'node:url';

const { dirname } = import.meta;
const { NODE_ENV = 'production' } = process.env;
const __dirname = dirname(fileURLToPath(import.meta.url));

@zachmargolis zachmargolis Oct 1, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the linter did not like the leading underscore here

Suggested change
const __dirname = dirname(fileURLToPath(import.meta.url));
const dirname = dirname(fileURLToPath(import.meta.url));


export default /** @type {import('webpack').Configuration} */ ({
mode: NODE_ENV,
Expand All @@ -17,7 +19,7 @@ export default /** @type {import('webpack').Configuration} */ ({
target: ['web'],
output: {
filename: '[name].js',
path: `${dirname}/_site/assets/js`,
path: `${__dirname}/_site/assets/js`,
},
resolve: {
extensions: ['.js', '.ts', '.tsx'],
Expand Down