Add links to source code from analytics events documentation#337
Merged
zachmargolis merged 2 commits intomainfrom Oct 25, 2022
Merged
Add links to source code from analytics events documentation#337zachmargolis merged 2 commits intomainfrom
zachmargolis merged 2 commits intomainfrom
Conversation
aduth
approved these changes
Oct 25, 2022
Comment on lines
+19
to
20
| className, | ||
| }: HeadingProps) { |
Contributor
There was a problem hiding this comment.
Could also consider forwarding along any valid HTML props.
Suggested change
| className, | |
| }: HeadingProps) { | |
| ...props, | |
| }: HeadingProps & JSX.HTMLAttributes<HTMLHeadingElement>) { |
Contributor
Author
There was a problem hiding this comment.
Ok! And we'd want to remove those from the definition of HeadingProps then, right?
Contributor
There was a problem hiding this comment.
Yeah there's a few more revisions that would need to be done in addition to that suggestion (also importing the JSX type and applying the props to TagName). The only thing we'd need to remove from the prop type is className.
Contributor
There was a problem hiding this comment.
y'know, in retrospect, I think this is fine as-is, if you want to just leave it.
Contributor
Author
There was a problem hiding this comment.
LOL ok will leave it
zachmargolis
commented
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: 18F/identity-idp#7208
Example:
It adds links to source definition, source usages
Screenshot: