Conversation
monfresh
force-pushed
the
mb-maintenance-updates
branch
4 times, most recently
from
ca5158a to
e6deda3
Compare
ajfarkas
left a comment
ajfarkas
left a comment
There was a problem hiding this comment.
This is great to see.
Are we not using store_test_results or store_artifacts in the circleCI config?
| echo 'export NVM_DIR="$HOME/.nvm"' >> $BASH_ENV; | ||
| echo '[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"' >> $BASH_ENV; | ||
|
|
||
| - node/install |
There was a problem hiding this comment.
Neat, I didn't know CircleCI had built-in support for NVM! That feels a lot nicer / safer than running code directly from GitHub 😅 I wonder if that's always been a thing, or if it's a new feature.
There was a problem hiding this comment.
I think this feature is relatively new. I forget when I first discovered it. Maybe in the past 2 years? It looks like the Node Orb was originally created in 2018, but I'm not sure if it had all of today's functionality back then.
| - node/install-packages | ||
| - ruby/install-deps |
There was a problem hiding this comment.
Also didn't realize they had these conveniences with built-in caching 🎉
There was a problem hiding this comment.
Yeah, and built-in test reporting as well.
|
@ajfarkas That's a good question. Previously, the With this new config, RSpec test results should be uploaded automatically, but it looks like the Node tests are not. Either way, given the nature of the tests, and that they run in about 30 seconds, I don't think we have much use for CircleCI's Test Insights. |
By default, the excerpt separator in Jekyll is a double newline. This is mainly for blogs that want to list the latest posts, but only show an excerpt. To determine how much of the beginning of the post to show in the excerpt, you define the stopping point by adding a double newline after it. Or you can specify your own custom separator. In a couple of our posts, namely `user-info.md` and `certificates.md`, the post content starts with a Liquid tag, and the content between the Liquid tags contains double newlines (i.e. an empty line between paragraphs). If excerpts were used, this would result in invalid Liquid syntax because the excerpt output would be missing the end Liquid tag. To overcome this, Jekyll inserts the closing tag to appease Liquid, but the output might be missing content, hence the warning. To get rid of this warning, I defined a custom excerpt separator in `_config.yml` References: https://jekyllrb.com/docs/posts/#post-excerpts https://talk.jekyllrb.com/t/whats-the-deal-with-found-a-liquid-block-containing-the-excerpt-separator-n-n/5289/4
With the new orbs that CircleCI provides, the config can be simplified. References: https://circleci.com/developer/orbs/orb/circleci/node https://circleci.com/developer/orbs/orb/circleci/ruby https://circleci.com/orbs/
monfresh
force-pushed
the
mb-maintenance-updates
branch
from
e6deda3 to
8d02355
Compare
4 participants
This PR contains some maintenance updates:
See the individual commit messages for more details.