Skip to content

LG-12103 Update embed code for lookbook sign in button component#473

Merged
nprimak merged 1 commit intomainfrom
np/LG-12103/embed-update-with-html-param
Apr 12, 2024
Merged

LG-12103 Update embed code for lookbook sign in button component#473
nprimak merged 1 commit intomainfrom
np/LG-12103/embed-update-with-html-param

Conversation

@nprimak
Copy link
Contributor

@nprimak nprimak commented Apr 11, 2024

Related to this PR was merged this morning that updates the lookbook component so that it has embedded styles that the partner can copy and paste ( not just the HTML )

Ticket: https://cm-jira.usa.gov/browse/LG-12103?filter=-1

This just updates the embed code to include the HTML (output) panel

NOTE: the build will not display the embed code properly, please visit

https://idp.dev.identitysandbox.gov/components/embed/login_button/workbench?_options=%257B%2522scenarios%2522%253A%255B%2522workbench%2522%255D%252C%2522panels%2522%253A%255B%2522params%2522%252C%2522output%2522%255D%257D&big=true

to see what the embed would look like

Copy link
Contributor

@ajfarkas ajfarkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Jeremy1026 Jeremy1026 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do it to it

@nprimak nprimak merged commit 93856e6 into main Apr 12, 2024
@nprimak nprimak deleted the np/LG-12103/embed-update-with-html-param branch April 12, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants